Remove ionicons #904
Open
Remove ionicons #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slifty
force-pushed
the
893-remove-ionicons
branch
from
6df183c to
d57eed4
Compare
slifty
force-pushed
the
893-remove-ionicons
branch
from
d57eed4 to
9943d69
Compare
We were using embedded SCSS from ionicons instead of their recommended approach which is to use web components + their npm package (though we WERE using their npm package). The original plan was to move to web components, but in doing so we realized that ionicons is one of three separate icon libraries we're using in the front end. Given this we decided that the best approach would be to remove ionicons entirely and use material icons for now. We expect to potentially migrate from material as well, but this is still a step in the right direction. Issue #893 Move to ionicons web components
slifty
force-pushed
the
893-remove-ionicons
branch
from
9943d69 to
59b362e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 47.82% 47.80% -0.02%
==========================================
Files 351 351
Lines 11292 11292
Branches 1889 1889
==========================================
- Hits 5400 5398 -2
+ Misses 5705 5701 -4
- Partials 187 193 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our use of
ionicons-- both as a package, or as included vendor code.Instances of ionicons have been replaced with material icons instead. Here's the specific list of locations:
Resolves #893
Related to #899