Skip to content

Enable unused parameter and require lint rules #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiftio wants to merge 1 commit into
base: 08-07-enable_additional_android_sample_lint_rules
Choose a base branch
from
+12 −12
Open

Enable unused parameter and require lint rules #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...app/src/main/java/com/shopify/checkoutkit/androiddemo/common/components/TextComponents.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ fun Header(
textAlign: TextAlign,
fontSize: TextUnit
) {
if (text == null && resourceId == null) {
throw IllegalArgumentException("No text or resourceId passed to Header component")
require(text != null || resourceId != null) {
"No text or resourceId passed to Header component"
}
Text(
text = text ?: stringResource(id = resourceId!!),
Expand Down
16 changes: 8 additions & 8 deletions ...app/src/main/java/com/shopify/checkoutkit/androiddemo/products/product/AddToCartButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
package com.shopify.checkoutkit.androiddemo.products.product

import androidx.compose.foundation.BorderStroke
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.TextButton
import androidx.compose.material3.LocalContentColor
import androidx.compose.material3.OutlinedButton
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.RectangleShape
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.unit.dp
import com.shopify.checkoutkit.androiddemo.R
import com.shopify.checkoutkit.androiddemo.common.components.Header3

Expand All @@ -23,21 +21,23 @@ fun AddToCartButton(
modifier: Modifier,
onClick: () -> Unit
) {
val buttonEnabled = enabled && !loading

Column(
modifier = modifier,
horizontalAlignment = Alignment.CenterHorizontally,
) {
TextButton(
OutlinedButton(
modifier = Modifier.fillMaxWidth(),
enabled = !loading,
enabled = buttonEnabled,
onClick = onClick,
border = BorderStroke(1.dp, MaterialTheme.colorScheme.onBackground),
shape = RectangleShape
shape = RectangleShape,
) {
Box {
Header3(
textAlign = TextAlign.Center,
text = stringResource(id = R.string.product_add_to_cart),
color = LocalContentColor.current,
)
}
}
Expand Down
4 changes: 2 additions & 2 deletions platforms/android/samples/CheckoutKitAndroidDemo/detekt.config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ style:
ThrowsCount:
active: false
UnusedParameter:
active: false
active: true
UseRequire:
active: false
active: true

formatting:
active: true
Expand Down
Loading