Add option to pass additional arguments

[ConorIA]

Target platforms this affects (Linux, Mac, Mac app store, and or Windows):

For now, I have only implemented this on Linux. I have to take a better look at how the Windows and Mac functions are structured. Of course, feedback from the Teamwork team is welcome.

What problem does this solve?

Addresses #46; Sometimes it is nice to pass additional command-line arguments to an app, for instance, Wire Desktop includes a flag --startup to start minimized. Now I can add extraArgs: "--startup", to my launcher so that the wire.desktop file includes the flag.

Could it break any existing functionality for users?

At least on Linux, I am confident that this shouldn't break any existing functionality.

[fredericlefeurmou]

When will this be merged?

[ConorIA]

It'd be great if someone with Mac/Windows experience could recommend how to make this work on those platforms. I can tinker, but I can't test on Mac. I can probably test on Windows, but don't have a testing environment set up, as I'm a full-time Linux user.

[adam-lynch]

Thanks for this. Could this apply to other platforms too? P.S. The README should be updated too.

[ConorIA]

As mentioned in previous comments, I don't have access to a Mac / Windows machine to test this, so Mac and Windows are currently untested.

[anuprajg]

This seems ready to be merged. Any plans to get this?

[damianobarbati]

Any news on this?

[Connum]

And yet again, half a year has passed...

[jaruba]

This saddens me greatly

[adam-lynch]

Please see that we're looking for contributors / maintainers: #64.

I'm happy to give access to people who are willing to help improve things, merge pull-requests, close issues, etc.

[Oxalin]

Not a big change, but I don't know if we should add parameters one after the other (extraArgs, onlyMe, etc.) or if this should be regrouped under and array of options.

[Oxalin]

Not that this PR is bad, but I would suggest to include this feature change in a broader and more flexible way. We should be able to push whatever argument, which should include "mac" and "isHiddenOnLaunch".

Let's push this change to a major version bump, which should also get ride of coffeescript (in favor of typescript?)

[4ver]

which should also get ride of coffeescript (in favor of typescript?)

Either that or just plain old js with jsdoc annotations 👌

[ConorIA]

Not that this PR is bad, but I would suggest to include this feature change in a broader and more flexible way.

As the person that hacked this PR together 7 years ago with no prior Coffeescript experience (and no experience since, either!), I will not take any offense to this PR being closed and done in a better / more flexible way.

[Oxalin]

What I would see is an @options object where we could define:
{appName, appPath, options} where would contain at least the following
optional object options: {
boolean isHiddenOnLaunch,
object mac {
boolean useLaunchAgent
},
array args
}

[Oxalin]

One PR will be merged under the "decaffeinate" branch which contains a new feature to add more arguments, I'll add a few more testcases to be sure additional arguments are properly added under all OSes.