Draft
Conversation
Contributor
Author
|
Might change the message later since it looks like we are only sending the difference in rotation between two hands, but i think we will probably need rotation of both hands 
|
Contributor
Author
|
Also ROS nodes/humanoid server haven't been changed to reflect these changes yet |
| # Not used by thumb | ||
| float32 flexion | ||
|
|
||
| # Not used by pinky |
Contributor
There was a problem hiding this comment.
Suggested change
| # Not used by pinky | |
| # Abduction is the angle between the fingers, so from 5 fingers, there are only 4 in-between-angles. E.g. index finger's abduction angle represent the angle between the index finger and the middle finger. | |
| # Not used by pinky coz the ring finger's abduction angle already represent the angle between the ring and pinky finger |
Comment on lines
+1
to
+10
| float32 curl | ||
|
|
||
| # Not used by thumb | ||
| float32 flexion | ||
|
|
||
| # Not used by pinky | ||
| float32 abduction | ||
|
|
||
| # Not used by thumb | ||
| float32 opposition No newline at end of file |
Contributor
There was a problem hiding this comment.
Wondering if the comments could be more descriptive on what each value represent? So the simulation team that is working on resolving the joint angle from it can sync up better with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.