-
Notifications
You must be signed in to change notification settings - Fork 2
Define hand data ROS message for VR #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
YichenLiu06
wants to merge
1
commit into
main
Choose a base branch
from
vr-hand-msg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| float32 curl | ||
|
|
||
| # Not used by thumb | ||
| float32 flexion | ||
|
|
||
| # Not used by pinky | ||
| float32 abduction | ||
|
|
||
| # Not used by thumb | ||
| float32 opposition | ||
|
Comment on lines
+1
to
+10
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wondering if the comments could be more descriptive on what each value represent? So the simulation team that is working on resolving the joint angle from it can sync up better with it |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| sample_msgs/FingerFeatures thumb | ||
| sample_msgs/FingerFeatures index | ||
| sample_msgs/FingerFeatures middle | ||
| sample_msgs/FingerFeatures ring | ||
| sample_msgs/FingerFeatures pinky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| std_msgs/Header header | ||
|
|
||
| smple_msgs/VRHandState left | ||
| sample_msgs/VRHandState right | ||
|
|
||
| # right hand position - left hand position | ||
| geometry_msgs/msg/Vector3 position_diff | ||
| float32 distance | ||
|
|
||
| # sin/cos of right hand rotation - left hand rotation | ||
| geometry_msgs/Vector3 rotation_diff_sin | ||
| geometry_msgs/Vector3 rotation_diff_cosa |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.