Address PR review: provider-agnostic auth error message and document concurrency cap#2
Closed
Copilot wants to merge 2 commits intoC/Gisa-CLIfrom
Closed
Address PR review: provider-agnostic auth error message and document concurrency cap#2Copilot wants to merge 2 commits intoC/Gisa-CLIfrom
Copilot wants to merge 2 commits intoC/Gisa-CLIfrom
Conversation
Merged
Co-authored-by: manuelgruber <156138+manuelgruber@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add discovery caching and improved CLI options
Address PR review: provider-agnostic auth error message and document concurrency cap
Feb 26, 2026
Member
|
Outdated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reviewer-flagged issues in the initial caching/SSH/clone PR.
Changes
src/auth/mod.rs— Auth fallback error message was hardcoded to GitHub (gh auth login,GITHUB_TOKEN, GitHub CLI docs link). Replaced with provider-agnostic guidance while keeping concrete examples inline:src/config/parser.rs—MAX_CONCURRENCY = 32had no rationale. Added comment: cap prevents file descriptor, memory, and CPU exhaustion on typical developer machines.Already resolved (no change needed)
src/errors/provider.rs:79— already genericsrc/auth/ssh.rs:14—StrictHostKeyChecking=noalready replaced withBatchMode=yessrc/cache/mod.rs:69— backward-clock guard already present🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.