Skip to content

Address PR review: provider-agnostic auth error message and document concurrency cap #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Address PR review: provider-agnostic auth error message and document concurrency cap #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e19f588
Initial plan
Copilot Feb 26, 2026
ea4975a
Address PR review: generic auth error and document concurrency limit
Copilot Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/auth/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,11 @@ pub fn get_auth(config_token: Option<&str>) -> Result<AuthResult, AppError> {
Err(AppError::auth(format!(
"No authentication found for your Git provider.\n\n\
Please authenticate using one of these methods:\n\n\
1. Provider CLI (recommended, e.g. GitHub CLI):\n \
gh auth login\n\n\
1. Provider CLI (recommended):\n \
e.g. `gh auth login` for GitHub\n\n\
2. Environment variable:\n \
export GITHUB_TOKEN=ghp_xxxx\n\
{}\n\
For more info: https://cli.github.com/manual/gh_auth_login",
e.g. GITHUB_TOKEN, GITLAB_TOKEN, or similar for your provider\n\
{}",
ssh_note
)))
}
Expand Down
2 changes: 2 additions & 0 deletions src/config/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ impl Config {
const MAX_CONCURRENCY: usize = 32;

// Validate concurrency
// 32 is chosen as a safe upper bound to prevent resource exhaustion
// (file descriptors, memory, CPU) on typical developer machines.
if !(1..=MAX_CONCURRENCY).contains(&self.concurrency) {
return Err(AppError::config(format!(
"concurrency must be between 1 and {}",
Expand Down