fix: tracksAssignment: false and tracksExposure: false in FetchOptions silently ignored#79
fix: tracksAssignment: false and tracksExposure: false in FetchOptions silently ignored#79
Conversation
…ed in doFetch Co-authored-by: zhukaihan <7332407+zhukaihan@users.noreply.github.com> Agent-Logs-Url: https://github.com/amplitude/experiment-node-server/sessions/2412ebe9-1de9-430e-9a90-ecca6ab958b2
|
@copilot Fix lint errors. |
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
5 similar comments
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@zhukaihan The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
| trackingOption: 'no-track', | ||
| exposureTrackingOption: 'no-track', |
There was a problem hiding this comment.
We already have tests for truthy cases.
tracksAssignment: falseandtracksExposure: falseinFetchOptionswere silently ignored indoFetchdue to truthy guards —falsevalues never produced'no-track'in the outgoing evaluation API request.Changes
packages/node/src/remote/client.ts: Replace truthy checks with!== undefined && !== nullguards so explicitfalsecorrectly maps to'no-track':packages/node/test/remote/client.test.ts: Add test case assertingtracksAssignment: false/tracksExposure: falseproducestrackingOption: 'no-track'/exposureTrackingOption: 'no-track'in the API call.Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.lab.amplitude.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node node ./node_modules/.bin/jest packages/node/test/remote/client.test.ts(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.