Skip to content

fix: tracksAssignment: false and tracksExposure: false in FetchOptions silently ignored #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+30 −4
Open

fix: tracksAssignment: false and tracksExposure: false in FetchOptions silently ignored #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c779928
Initial plan
Copilot Mar 23, 2026
dbb015f
Fix tracksAssignment/tracksExposure false values being silently ignor…
Copilot Mar 23, 2026
3cd6a36
lint: fix lint
zhukaihan Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/node/src/remote/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,20 @@ export class RemoteEvaluationClient {
flagKeys: options?.flagKeys,
timeoutMillis: timeoutMillis,
};
if (options?.tracksAssignment) {
getVariantsOptions.trackingOption = options?.tracksAssignment
if (
options?.tracksAssignment !== undefined &&
options?.tracksAssignment !== null
) {
getVariantsOptions.trackingOption = options.tracksAssignment
? 'track'
: 'no-track';
}
if (options?.tracksExposure) {
if (
options?.tracksExposure !== undefined &&
options?.tracksExposure !== null
) {
(getVariantsOptions as any).exposureTrackingOption =
options?.tracksExposure ? 'track' : 'no-track';
options.tracksExposure ? 'track' : 'no-track';
}
const results = await this.evaluationApi.getVariants(
userContext,
Expand Down
20 changes: 20 additions & 0 deletions packages/node/test/remote/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,26 @@ describe('ExperimentClient.fetch', () => {
}),
);
});

test('ExperimentClient.fetch, v2 tracksAssignment false and tracksExposure false', async () => {
const client = new RemoteEvaluationClient(API_KEY, {});
const getVariantsSpy = jest.spyOn(
(client as any).evaluationApi,
'getVariants',
);
const variants = await client.fetchV2(testUser, {
tracksAssignment: false,
tracksExposure: false,
});
expect(variants['sdk-ci-test'].key).toEqual('on');
expect(getVariantsSpy).toHaveBeenCalledWith(
expect.objectContaining(testUser),
expect.objectContaining({
trackingOption: 'no-track',
exposureTrackingOption: 'no-track',
Comment on lines +122 to +123
Copy link
Collaborator

@zhukaihan zhukaihan Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have tests for truthy cases.

}),
);
});
});

describe('ExperimentClient.fetch, retry with different response codes', () => {
Expand Down
Loading