feat: support pushdown alias on dynamic filter with ProjectionExec
#19404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-plan
discord9
changed the title
ProjectionExecProjectionExec
discord9
changed the title
ProjectionExecProjectionExec
Contributor
Author
|
@jackkleeman @adriangb hi, I added the projection alias support in #17246, since you have the most context on this, could you please take a look when you have a chance? |
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
…test: filter pushdown projection Signed-off-by: discord9 <[email protected]>
…iter&test: unit test Signed-off-by: discord9 <[email protected]>
…t assertions Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
…output Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
Signed-off-by: discord9 <[email protected]>
discord9
force-pushed
the
feat/dyn_filter_alias
branch
from
ee4e327 to
4775fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
For dynamic filter to work properly, table scan must get correct column even if it's passing through alias(by
ProjectionExec) hence need to modify parent filter whengather_filters_for_pushdownWhat changes are included in this PR?
as title, add support for handling simple alias in pushdown filter, which expand aliased column(in pushdown filter) to it's original expressions(or
UnKnownColumnif can't found aliased column in pushdown filter) so alias in projection is supported, also added unit tests.AI Content claim: the core logic is hand written and thoroughly understood, but unit test are largely generated with some human guidance
Are these changes tested?
Unit tests are added, please comment if more tests are needed
Are there any user-facing changes?
Yes, dynamic filter will work properly with alias now, I'm not sure if that count as breaking change though?