-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: support pushdown alias on dynamic filter with ProjectionExec
#19404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
discord9
wants to merge
14
commits into
apache:main
Choose a base branch
from
discord9:feat/dyn_filter_alias
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+727
−9
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
22ccf41
feat: wrong version which did weird stuff
discord9 2304e3f
feat: gather filter support alias
discord9 cc2fbe2
feat: add support for detecting unknown columns in filter pushdown & …
discord9 18e58c1
feat: update projection alias handling and enhance PhysicalColumnRewr…
discord9 e911c6b
feat: update deeply nested expression helper function and enhance tes…
discord9 ca44635
chore: clippy
discord9 4dd72eb
typo
discord9 e289ff7
feat: update test assertions for filter pushdown to reflect expected …
discord9 502faf8
c
discord9 575a69f
c
discord9 1085bb6
clippy
discord9 d363d98
test: update sqllogic test result
discord9 2862c98
test: more complex dyn filter
discord9 0ccefc8
c
discord9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the correct grammar would be
has_unknown_columns(expr)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs a docstring.