Lower backup role failure severity for IO error - #13872
Open
mpatou-openai wants to merge 1 commit into
Open
Conversation
mpatou-openai
marked this pull request as ready for review
August 15, 2026 02:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
One off IO error when doing backup in the backup-worker when using backup-v2/partitioned logs is causing the process to report for the next 24 hours an SevError that could lead to pagable alert depending on once configuration.
Solution:
Make this issue a non SevError for the backup-worker due to the nature of the medium used for backup ie. blobstore or networked filesystem it can happen and will be retried by the process.
Testing:
Passed 10K testing in joshua