Skip to content

Lower backup role failure severity for IO error #13872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpatou-openai wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Lower backup role failure severity for IO error #13872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fdbserver/core/WorkerSupport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ void endRole(const Role& role, UID id, std::string reason, bool ok, Error e) {
if (!ok) {
std::string type = role.roleName + "Failed";

TraceEvent err(SevError, type.c_str(), id);
TraceEvent err(role == Role::BACKUP ? SevWarnAlways : SevError, type.c_str(), id);
if (e.code() != invalid_error_code) {
err.errorUnsuppressed(e);
}
Expand Down
Loading