Add Correct Initial Audio Settings#375
Merged
terminal-overflow merged 4 commits intomasterfrom Mar 26, 2025
Merged
Conversation
ShiningTrapez
previously approved these changes
Mar 24, 2025
Contributor
|
Good Work! 👏 |
eirikbjornr
previously approved these changes
Mar 24, 2025
Contributor
eirikbjornr
left a comment
There was a problem hiding this comment.
Nice! One nitpick improvement so feel free to go ahead without it
0800f76
ShiningTrapez
previously approved these changes
Mar 24, 2025
eirikbjornr
previously approved these changes
Mar 24, 2025
3d09aa2
eirikbjornr
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📺 What
Dash.js caches the last track used in local storage and selects the audio track based on selection priority and then max bitrate. This can result in the BroadcastMixAD (Audio Described) being selected against the users preference. This can manifest in two scenarios.
In both scenarios, the BroadcastMixAD track is selected when the users AD preference is off. This PR disables dash.js's media track caching and sets an initial audio preference.
🛠 How
lastMediaSettingsCachingInforole: mainif Audio Described is not enabled at the start of stream.