Skip to content

Add Correct Initial Audio Settings #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terminal-overflow merged 4 commits into from
Mar 26, 2025
Merged

Add Correct Initial Audio Settings #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c6825f
disable media settings cache
terminal-overflow Mar 24, 2025
30d01fa
add initial settings unit tests
terminal-overflow Mar 24, 2025
0800f76
convert setInitialMediaSettings call into a ternary
terminal-overflow Mar 24, 2025
3d09aa2
update naming
terminal-overflow Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/playbackstrategy/msestrategy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ function MSEStrategy(
bufferTimeAtTopQuality: 12,
bufferTimeAtTopQualityLongForm: 15,
},
lastMediaSettingsCachingInfo: { enabled: false },
},
},
customPlayerSettings
Expand Down Expand Up @@ -526,12 +527,17 @@ function MSEStrategy(
mediaPlayer.updateSettings(dashSettings)
mediaPlayer.initialize(mediaElement, null)

if (audioDescribed.enable) {
mediaPlayer.setInitialMediaSettingsFor("audio", {
role: "alternate",
accessibility: { schemeIdUri: "urn:tva:metadata:cs:AudioPurposeCS:2007", value: "1" },
})
}
mediaPlayer.setInitialMediaSettingsFor(
"audio",
audioDescribed.enable
? {
role: "alternate",
accessibility: { schemeIdUri: "urn:tva:metadata:cs:AudioPurposeCS:2007", value: "1" },
}
: {
role: "main",
}
)

modifySource(presentationTimeInSeconds)
}
Expand Down
8 changes: 5 additions & 3 deletions src/playbackstrategy/msestrategy.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ describe("Media Source Extensions Playback Strategy", () => {
})

describe("Sets up mediaPlayer respecting audioDescribed.enable", () => {
it("sets initial audio track settings when audioDescribed.enable is true", () => {
it("sets initial audio settings to the audio described track when audio described is enabled", () => {
const mseStrategy = MSEStrategy(mockMediaSources, MediaKinds.VIDEO, playbackElement, undefined, undefined, {
enable: true,
})
Expand All @@ -714,13 +714,15 @@ describe("Media Source Extensions Playback Strategy", () => {
})
})

it("does not set initial audio track settings when audioDescribed.enable is false", () => {
it("sets initial audio settings to main track when audio described is not enabled", () => {
const mseStrategy = MSEStrategy(mockMediaSources, MediaKinds.VIDEO, playbackElement, undefined, undefined, {
enable: false,
})
mseStrategy.load(null, 10)

expect(mockDashInstance.setInitialMediaSettingsFor).not.toHaveBeenCalled()
expect(mockDashInstance.setInitialMediaSettingsFor).toHaveBeenCalledWith("audio", {
role: "main",
})
})
})

Expand Down