Support aggregate size computations over list, maps, and structs - #1404
Merged
Conversation
TristonianJones
force-pushed
the
aggregate-size
branch
from
August 7, 2026 18:29
efe3a1b to
42e38b0
Compare
l46kok
reviewed
Aug 11, 2026
l46kok
previously approved these changes
Aug 14, 2026
l46kok
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support best cost tracking, introduce version-aware
AggregateSizemethodson list, map, and object types.
The implementations currently memoize aggregate size computations
for immutable objects. The aggregate size is capped at
uint32to minimizethe allocation overhead associated with the book-keeping fields on these
objects.
As far as possible, the allocation cost associated computing the size
list, maps, and structs has been reduced to a minimum. The purpose of
having different, or versioned,
AggregateSizeimplementations is to allowusers to tailor which kinds of costs they're willing to consider before giving
up and assigning a maximum size.