-
Notifications
You must be signed in to change notification settings - Fork 307
Support aggregate size computations over list, maps, and structs #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TristonianJones
merged 3 commits into
cel-expr:master
from
TristonianJones:aggregate-size
Aug 15, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
42e38b0
Support aggregate size computations over list, maps, and structs
TristonianJones 1049806
Depth and traversal limits for aggregate size calculations
TristonianJones 98b642a
Enhancements to use Foldable and reduce duplication in native size co…
TristonianJones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package types | ||
|
|
||
| // AggregateSizer calculates the recursive element size of values. | ||
| type AggregateSizer interface { | ||
| // AggregateSize returns the size of the input value, if known. | ||
| // Otherwise, a unit size of 1 is returned. | ||
| AggregateSize(val any) uint32 | ||
| } | ||
|
|
||
| // AggregateSizeVisitor interface for ref.Val implementations capable of returning | ||
| // their total recursive element count. | ||
| type AggregateSizeVisitor interface { | ||
| // AggregateSize returns the total count of nested atomic elements (capped at math.MaxUint32). | ||
| AggregateSize(sizer AggregateSizer) uint32 | ||
| } | ||
|
|
||
| // Helper for computing aggregate sizes of traits.Foldable types. | ||
| type foldableAggregateSizer struct { | ||
| sizer AggregateSizer | ||
| total uint32 | ||
| } | ||
|
|
||
| // FoldEntry implements the traits.FoldEntry interface method and counts the aggregate size | ||
| // keys and values. | ||
| func (f *foldableAggregateSizer) FoldEntry(k, v any) bool { | ||
| f.total = safeAddUint32(f.total, f.sizer.AggregateSize(k)) | ||
| f.total = safeAddUint32(f.total, f.sizer.AggregateSize(v)) | ||
| return true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.