2.0: [Rust] Remove RLS bindings [Not to merge] #4135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext (#4101) # Description of Changes Makes the `sender` field on `ViewContext` private and exposes a `sender()` method. Does the same for `ReducerContext` and `ProcedureContext`. The purpose of this change: So that the host can determine if/when a view invokes or reads the `sender`. Currently, because `sender` is a field, the host assumes that it is always read. This means views must be materialized per client, even if the view doesn't actually depend on `sender`, resulting in data duplication. The initial solution for this problem was `AnonymousViewContext` which doesn't have a `sender` field. The better solution is to make `sender` a method so that it can call into the host and record when it's actually invoked. Note, this patch only updates the module API, so the current implementation does not change. `ViewContext` views are still duplicated across clients. Changing this requires a new host syscall and for `sender()` to invoke that syscall. This however is backwards compatible and can be done anytime after the module APIs for the other languages (C#, TypeScript, C++) are updated. Also note that `ReducerContext` and `ProcedureContext` were updated purely for consistency. There are currently no plans to track reads of `sender` in these contexts. # API and ABI breaking changes Breaks the rust module api. # Expected complexity level and risk 1 # Testing N/A
Shubham8287
force-pushed
the
shub/deprecate-rls
branch
3 times, most recently
from
40994e4 to
273d2a9
Compare
Shubham8287
force-pushed
the
shub/deprecate-rls
branch
from
273d2a9 to
a4cf1e9
Compare
gefjon
approved these changes
Jan 27, 2026
Contributor
gefjon
left a comment
gefjon
left a comment
There was a problem hiding this comment.
That's... not really what deprecation is. This PR is just removing RLS. Deprecation would involve leaving the functionality in place, but with a warning that it should not be used and will be removed in the future.
That's not to say that we should deprecate RLS, we should definitely just remove it in 2.0 modules, 'cause the migration to views with the typed query builder is easy. Just, please change the PR title to "Remove RLS interface from bindings"
Shubham8287
changed the title
Shubham8287
changed the title
Shubham8287
force-pushed
the
2.0-breaking-changes
branch
from
5831494 to
85dc1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove RLS bindings for 2.0.
API and ABI breaking changes
Older modules with RLS should continue to work.
Testing:
This PR is suppose to remove the interface, hence deletes smoketest and integration tests.
though we may want to keep some unit tests as we still support RLS in older modules. I will check for them before merging the PR.
Expected complexity level and risk
1