Skip to content

MENDELU/Add dc.relation.funder to item view#1265

Merged
milanmajchrak merged 6 commits intocustomer/mendelufrom
mendelu/funder-to-item-view
Mar 25, 2026
Merged

MENDELU/Add dc.relation.funder to item view#1265
milanmajchrak merged 6 commits intocustomer/mendelufrom
mendelu/funder-to-item-view

Conversation

@Kasinhou
Copy link
Copy Markdown

@Kasinhou Kasinhou commented Mar 24, 2026

Problem description

Issue: https://github.com/dataquest-dev/dspace-customers/issues/512

Sync verification

If en.json5 or cs.json5 translation files were updated:

  • Run yarn run sync-i18n -t src/assets/i18n/cs.json5 -i to synchronize messages, and changes are included in this PR.

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

@Kasinhou Kasinhou self-assigned this Mar 24, 2026
@Kasinhou
Copy link
Copy Markdown
Author

current state:

image

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “Funder” field to simple item view pages (Publication + Untyped item) to surface dc.relation.funder, including i18n labels.

Changes:

  • Adds ds-item-page-funder-field into the publication and untyped item simple page templates.
  • Registers/imports ItemPageFunderFieldComponent in both base app and custom theme standalone item type components.
  • Adds i18n label item.page.funder in en.json5 and cs.json5.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/themes/custom/app/item-page/simple/item-types/untyped-item/untyped-item.component.ts Adds funder field component import to the themed untyped item standalone imports.
src/themes/custom/app/item-page/simple/item-types/publication/publication.component.ts Adds funder field component import to the themed publication standalone imports.
src/assets/i18n/en.json5 Adds English label for “Funder”.
src/assets/i18n/cs.json5 Adds Czech label for “Funder” (with the usual commented English source line).
src/app/item-page/simple/item-types/untyped-item/untyped-item.component.ts Adds funder field component import to base untyped item standalone imports.
src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html Renders the new ds-item-page-funder-field in the untyped item page.
src/app/item-page/simple/item-types/publication/publication.component.ts Adds funder field component import to base publication standalone imports.
src/app/item-page/simple/item-types/publication/publication.component.html Renders the new ds-item-page-funder-field in the publication page.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

@Kasinhou Kasinhou requested a review from milanmajchrak March 25, 2026 08:34
@milanmajchrak milanmajchrak self-requested a review March 25, 2026 13:50
@milanmajchrak milanmajchrak merged commit 8017ee3 into customer/mendelu Mar 25, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants