forked from DSpace/dspace-angular
-
Notifications
You must be signed in to change notification settings - Fork 2
MENDELU/Add dc.relation.funder to item view #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d7bc873
Created item page funder field component
431ce97
Added component and fixed lint errors
7fc08cb
Simplify approach to use only exact match
f266e0f
Fetched mapping from backend
eb578ab
Fix order of imports
ed4bb52
Translated funder to more specific text
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
...-page/simple/field-components/specific-field/funder/item-page-funder-field.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <ds-metadata-field-wrapper [label]="label | translate"> | ||
| @for (name of funderNames; track name; let last = $last) { | ||
| <span class="dont-break-out">{{ name }}</span> | ||
| @if (!last) { | ||
| <span class="separator" [innerHTML]="separator"></span> | ||
| } | ||
| } | ||
| </ds-metadata-field-wrapper> |
63 changes: 63 additions & 0 deletions
63
...em-page/simple/field-components/specific-field/funder/item-page-funder-field.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { | ||
| Component, | ||
| Input, | ||
| OnInit, | ||
| } from '@angular/core'; | ||
| import { TranslateModule } from '@ngx-translate/core'; | ||
|
|
||
| import { ConfigurationDataService } from '../../../../../core/data/configuration-data.service'; | ||
| import { Item } from '../../../../../core/shared/item.model'; | ||
| import { MetadataValue } from '../../../../../core/shared/metadata.models'; | ||
| import { getFirstCompletedRemoteData } from '../../../../../core/shared/operators'; | ||
| import { MetadataFieldWrapperComponent } from '../../../../../shared/metadata-field-wrapper/metadata-field-wrapper.component'; | ||
|
|
||
| @Component({ | ||
| selector: 'ds-item-page-funder-field', | ||
| templateUrl: './item-page-funder-field.component.html', | ||
| standalone: true, | ||
| imports: [ | ||
| MetadataFieldWrapperComponent, | ||
| TranslateModule, | ||
| ], | ||
| }) | ||
| /** | ||
| * Component for displaying dc.relation.funder metadata on the simple item page. | ||
| * Funder code-to-name mapping is fetched from the backend configuration property "funder.name.map". | ||
| */ | ||
| export class ItemPageFunderFieldComponent implements OnInit { | ||
|
|
||
| @Input() item: Item; | ||
|
|
||
| @Input() label = 'item.page.funder'; | ||
|
|
||
| @Input() separator = ', '; | ||
|
|
||
| funderNames: string[] = []; | ||
|
|
||
| constructor( | ||
| private configurationService: ConfigurationDataService, | ||
| ) {} | ||
|
|
||
| ngOnInit(): void { | ||
| const mdValues: MetadataValue[] = this.item?.allMetadata(['dc.relation.funder']) ?? []; | ||
| if (mdValues.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| this.configurationService.findByPropertyName('funder.name.map').pipe( | ||
| getFirstCompletedRemoteData(), | ||
| ).subscribe(rd => { | ||
| const nameMap: Record<string, string> = {}; | ||
| if (rd.hasSucceeded && rd.payload?.values) { | ||
| for (const entry of rd.payload.values) { | ||
| const eqIndex = entry.indexOf('='); | ||
| if (eqIndex > 0) { | ||
| nameMap[entry.substring(0, eqIndex).trim()] = entry.substring(eqIndex + 1).trim(); | ||
| } | ||
| } | ||
| } | ||
| const resolved = mdValues.map(md => nameMap[md.value] ?? md.value); | ||
| this.funderNames = [...new Set(resolved)]; | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.