Skip to content

fix: update Dockerfile for post-PR#59 package layout#69

Merged
abyot merged 2 commits intomainfrom
docker-fix
May 7, 2026
Merged

fix: update Dockerfile for post-PR#59 package layout#69
abyot merged 2 commits intomainfrom
docker-fix

Conversation

@turban
Copy link
Copy Markdown
Contributor

@turban turban commented May 7, 2026

The Docker build was broken after PR #59 moved several files into the package. The Dockerfile still tried to COPY paths that no longer exist:

  • data/datasets/ — moved to src/climate_api/data/datasets/ as bundled package data
  • data/extents.yaml — removed entirely (replaced by extent: in CLIMATE_API_CONFIG)
  • config/pygeoapi/base.yml — moved to src/climate_api/data/pygeoapi/base.yml as bundled package data

Changes:

data/datasets/, data/extents.yaml, and config/pygeoapi/base.yml no longer
exist as repo-level files — they were moved into src/climate_api/data/ as
bundled package data in PR #59. Remove the stale COPY instructions and
delete config/pygeoapi/base.yml (superseded by src/climate_api/data/pygeoapi/base.yml).

Set CACHE_OVERRIDE=/app/data so all runtime paths (downloads, artifacts,
pygeoapi) resolve consistently under /app/data in the container.
@turban turban requested a review from abyot May 7, 2026 09:59
Copy link
Copy Markdown
Member

@abyot abyot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the README pygeoapi section so it reflects the new bundled-base-config and runtime-generated paths.

## pygeoapi

The OGC API is served by pygeoapi, mounted at `/ogcapi`. Its configuration is generated dynamically from published artifacts and written to the resolved runtime data directory (for Docker: `/app/data/pygeoapi/pygeoapi-config.yml`).

Copy link
Copy Markdown
Contributor Author

@turban turban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — updated the pygeoapi section in README.md to reflect the bundled base config and runtime-resolved paths. The reference to config/pygeoapi/base.yml has also been removed from the regeneration note since that file no longer exists.

@abyot abyot merged commit a8004c0 into main May 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants