JIT: formatting fixes in rangecheck.h#131104
Merged
AaronRobinsonMSFT merged 1 commit intoJul 21, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60b9ea03-ba01-436d-a52a-06abec2fad32
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
Author
|
/cc @dotnet/jit-contrib |
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small formatting adjustments in src/coreclr/jit/rangecheck.h to improve readability by wrapping/realigning a couple of long boolean expressions in RangeOps::Add, without changing logic.
Changes:
- Reflows the
r1StraddlesZero/r2StraddlesZerocomputations for readability. - Wraps the
signedEndpointOverflowsassignment to avoid an overly long line.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/rangecheck.h | Formatting-only line wrapping in RangeOps::Add (no behavioral changes). |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
tannergooding
approved these changes
Jul 20, 2026
EgorBo
approved these changes
Jul 20, 2026
AaronRobinsonMSFT
enabled auto-merge (squash)
July 20, 2026 21:20
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor formatting-only changes in
src/coreclr/jit/rangecheck.hto wrap long lines. No behavioral changes.Note
This PR description was generated with the assistance of GitHub Copilot.