Skip to content

JIT: formatting fixes in rangecheck.h #131104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 1 commit into from
Jul 21, 2026
Merged

JIT: formatting fixes in rangecheck.h #131104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/coreclr/jit/rangecheck.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,10 @@ struct RangeOps
{
if (unsignedAdd)
{
bool r1StraddlesZero = r1.IsConstantRange() && (r1.LowerLimit().GetConstant() < 0) &&
(r1.UpperLimit().GetConstant() >= 0);
bool r2StraddlesZero = r2.IsConstantRange() && (r2.LowerLimit().GetConstant() < 0) &&
(r2.UpperLimit().GetConstant() >= 0);
bool r1StraddlesZero =
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.
r1.IsConstantRange() && (r1.LowerLimit().GetConstant() < 0) && (r1.UpperLimit().GetConstant() >= 0);
bool r2StraddlesZero =
r2.IsConstantRange() && (r2.LowerLimit().GetConstant() < 0) && (r2.UpperLimit().GetConstant() >= 0);
if (r1StraddlesZero || r2StraddlesZero)
{
// Signed intervals that straddle zero are not monotonic when interpreted as unsigned.
Expand All @@ -355,7 +355,8 @@ struct RangeOps
static_assert(CheckedOps::Unsigned == true);
// For unsigned adds, require both unsigned and signed endpoint sums to not overflow.
bool requestedAddOverflows = CheckedOps::AddOverflows(a.GetConstant(), b.GetConstant(), unsignedAdd);
bool signedEndpointOverflows = unsignedAdd && CheckedOps::AddOverflows(a.GetConstant(), b.GetConstant(), CheckedOps::Signed);
bool signedEndpointOverflows =
unsignedAdd && CheckedOps::AddOverflows(a.GetConstant(), b.GetConstant(), CheckedOps::Signed);
if (!requestedAddOverflows && !signedEndpointOverflows)
{
if (a.IsConstant() && b.IsConstant())
Expand Down
Loading