Use C11 _Thread_local for current locale. NFC#26486
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Mar 18, 2026
Merged
Use C11 _Thread_local for current locale. NFC#26486sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Member
|
This looks reasonable, but what's the endgame? How many of these are there going to be? |
Collaborator
Author
|
My goal is to make is to remove I think for these two struct member it makes a lot of sense to use normal TLS here, espcially since its a code size saving! |
Collaborator
Author
dschuff
reviewed
Mar 18, 2026
We already do a similar thing for `__errno_location`. This means that locale usage no longer depends on pthread_self, which means it works correctly in Wasm Workers. I guess the codesize savings here come from the fact that the TLS data doesn't need to initialized programmatically anymore.
dschuff
approved these changes
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 19, 2026
This test was being very naughty indeed. The test was added back in 2017 in emscripten-core#4813, although its hard to say what exactly its purpose is.
sbc100
added a commit
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already do a similar thing for
__errno_location.This means that locale usage no longer depends on pthread_self, which means it works correctly in Wasm Workers.
I guess the codesize savings here come from the fact that the TLS data doesn't need to initialized programmatically anymore.