Remove remaining pthread function from WASM_WORKERS build#26487
Open
sbc100 wants to merge 2 commits intoemscripten-core:mainfrom
Open
Remove remaining pthread function from WASM_WORKERS build#26487sbc100 wants to merge 2 commits intoemscripten-core:mainfrom
sbc100 wants to merge 2 commits intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
4cb407b to
80b40f3
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 18, 2026
…n_futex_wait`. NFC This means we only need to do this breaking up on our `wait` operations in a single place. It also means that other users the `emscripten_futex_wait` API don't break pthread proxying or async cancellation. The moved code is only included in pthread-enabled builds so should not effect Wasm Workers builders. This change also paves the way for enabling musl's `__wait` to work with `WASM_WORKERS`.
This includes `pthread_self`, which is not valid to call in Wasm Workers.
sbc100
force-pushed
the
wasm_workers_no_pthreads
branch
from
80b40f3 to
1da8fe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove remaining pthread function from WASM_WORKERS build. NFC
This includes
pthread_self, which is not valid to call in WasmWorkers.
This PR is currently stacked on top of both #26486 and #26471