Fix ESP-IDF Manager empty list when opened before IDF installation#1430
Open
Fix ESP-IDF Manager empty list when opened before IDF installation#1430
Conversation
The issue was that refreshEditorUI() was not called when eimJson was null, which happens when the ESP-IDF Manager is opened before any IDF is installed. Changes: - Always call refreshEditorUI() in createPage() to ensure the table is populated from the eim_idf.json file regardless of initial eimJson state - Change refreshEditorUI() to return CompletableFuture<Void> to enable proper sequencing of async operations - Fix race condition in refreshAfterEimClose() where setupInitialEspIdf() was called before refreshEditorUI() completed, causing it to see an empty table Agent-Logs-Url: https://github.com/espressif/idf-eclipse-plugin/sessions/ca8282ac-e486-4a42-80b0-921e40dfd062 Co-authored-by: kolipakakondal <8463287+kolipakakondal@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ESP IDF manager not displaying installed SDKs
Fix ESP-IDF Manager empty list when opened before IDF installation
Apr 9, 2026
The questioner correctly identified that calling refreshEditorUI() when eimJson is null is pointless: if eimJson is null it means eim_idf.json could not be loaded, so refreshEditorUI() would also find nothing and just show an empty table. The original null guard (if eimJson != null) is correct and is restored. The only meaningful fix from the previous session is the race-condition fix in refreshAfterEimClose(), where setupInitialEspIdf() is now chained via thenRun() so it runs after the async refresh has populated the table. Agent-Logs-Url: https://github.com/espressif/idf-eclipse-plugin/sessions/9d212ef8-49c5-46be-b9aa-b3d696c5136a Co-authored-by: kolipakakondal <8463287+kolipakakondal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refreshEditorUI()wheneimJsonis null is pointless — ifeimJsonis null theeim_idf.jsonfile does not exist, so the refresh will find nothingcreatePage()to restore the originalif (eimJson != null)guardrefreshAfterEimClose()(thenRun()chain)