Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change updates the regex pattern used to extract ESP32 chip identifiers from device info output. The pattern now matches both "Chip is" and "Chip type:" prefixes with case-insensitive comparison, expanding compatibility with different firmware chip info response formats. ChangesSerial Chip Detection Regex Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
With ESP-IDF 6.0.1, the output format of the esptool detection script has changed. The script now prints Chip type: instead of Chip: during target detection, causing the current regex to fail.
Example output:
Detecting chip type... ESP32
Connected to ESP32 on COM4:
Chip type: ESP32-D0WD-V3 (revision v3.0)
So in this PR I've changed the regex to support both type of output
Chip isandChip typeFixes # (IEP-1764)
Type of change
Please delete options that are not relevant.
How has this been tested?
Install esp-idf 5.2 and esp-idf 6.0.1 and check target detection on both of them
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit