Skip to content

IEP-1764 Target detection is failing with ESP-IDF 6.0.1#1458

Open
sigmaaa wants to merge 1 commit intomasterfrom
IEP-1764
Open

IEP-1764 Target detection is failing with ESP-IDF 6.0.1#1458
sigmaaa wants to merge 1 commit intomasterfrom
IEP-1764

Conversation

@sigmaaa
Copy link
Copy Markdown
Collaborator

@sigmaaa sigmaaa commented May 7, 2026

Description

With ESP-IDF 6.0.1, the output format of the esptool detection script has changed. The script now prints Chip type: instead of Chip: during target detection, causing the current regex to fail.

Example output:
Detecting chip type... ESP32
Connected to ESP32 on COM4:
Chip type: ESP32-D0WD-V3 (revision v3.0)

So in this PR I've changed the regex to support both type of output Chip is and Chip type

Fixes # (IEP-1764)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Install esp-idf 5.2 and esp-idf 6.0.1 and check target detection on both of them

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced chip type detection in the serial flash target wizard to support additional device identification output formats, improving compatibility when detecting target devices.

@sigmaaa sigmaaa self-assigned this May 7, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d51f2a05-9cee-48a6-b54c-304567afe581

📥 Commits

Reviewing files that changed from the base of the PR and between 1b99852 and 1957a89.

📒 Files selected for processing (1)
  • bundles/com.espressif.idf.launch.serial.ui/src/com/espressif/idf/launch/serial/ui/internal/NewSerialFlashTargetWizardPage.java

📝 Walkthrough

Walkthrough

The change updates the regex pattern used to extract ESP32 chip identifiers from device info output. The pattern now matches both "Chip is" and "Chip type:" prefixes with case-insensitive comparison, expanding compatibility with different firmware chip info response formats.

Changes

Serial Chip Detection Regex Update

Layer / File(s) Summary
Chip Detection Pattern
bundles/com.espressif.idf.launch.serial.ui/src/com/espressif/idf/launch/serial/ui/internal/NewSerialFlashTargetWizardPage.java
Pattern for extracting chip type from device output is updated to match "Chip is" or "Chip type:" prefixes (case-insensitive) instead of only "Chip is".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • kolipakakondal
  • AndriiFilippov
  • alirana01

Poem

🐰 A pattern learns to speak in two new ways,
"Chip is" and "type:" now both pass our gaze,
Case-insensitive wisdom flows through the regex,
One tiny line change, but devices rejoice and flex! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing target detection failures caused by ESP-IDF 6.0.1's different output format by updating the chip-type extraction regex.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch IEP-1764

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sigmaaa sigmaaa added this to the v4.2.1 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant