Skip to content

IEP-1764 Target detection is failing with ESP-IDF 6.0.1 #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sigmaaa wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

IEP-1764 Target detection is failing with ESP-IDF 6.0.1 #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...al.ui/src/com/espressif/idf/launch/serial/ui/internal/NewSerialFlashTargetWizardPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ protected IStatus run(IProgressMonitor monitor)

private String extractChipFromChipInfoOutput(String chipInfoOutput)
{
Pattern pattern = Pattern.compile("Chip is (ESP32[^\\s]*)"); //$NON-NLS-1$
Pattern pattern = Pattern.compile("(?:Chip is|Chip type:)\\s+(ESP32[^\\s]*)", Pattern.CASE_INSENSITIVE); //$NON-NLS-1$
Copy link
Copy Markdown
Collaborator

@kolipakakondal kolipakakondal May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though it works for now, I think we initially took the wrong approach to parsing the log output, since it’s subject to change. We should request JSON output from esptool instead and look for specific keys. I will raise a request for this.

https://docs.espressif.com/projects/esptool/en/latest/esp32/migration-guide.html#log-format-changes

Make sure to adjust any of your scripts, asserts, CI workflows, or others to accommodate the new/changed format of messages. If you are parsing the log output (not recommended), consider importing esptool as a module and using the public API (see here) to get the information you need.

Matcher matcher = pattern.matcher(chipInfoOutput);
if (matcher.find())
{
Expand Down
Loading