add support for optional chaining by sanex3339 · Pull Request #412 · estools/escodegen

sanex3339 · 2020-05-30T16:42:30Z

Spec:
https://github.com/estree/estree/pull/204/files

sanex3339 · 2020-06-11T07:56:46Z

acornjs/acorn#891 merged, will back to this PR this weekend

sanex3339 · 2020-06-11T11:39:57Z

Updated this PR

sanex3339 · 2020-06-11T11:40:15Z

@michaelficarra 👀

test/compare-acorn-es2020/optional-chaining.expected.js

sanex3339 · 2020-06-12T21:56:29Z

@michaelficarra should we support node@4 in travis? I added chai-exclude package to deep compare AST-trees without start and end properties, but looks like it doesn't support node@4.

I can remove node@4 from travis.yml and add node@10 instead

sanex3339 · 2020-06-12T22:07:02Z

Ok. I removed node@4 from travis.yml file and added node@10 instead.
Also, I updated engines section with >=6.0 value.

Node 4 is few years as deprecated, so I think it's the time to leave this version

sanex3339 · 2020-06-13T07:54:03Z

@michaelficarra also i created PR to the estraverse to support ChainExpression node.
estools/estraverse#113

So it is best to merge estravserse PR first and after that, I'll update this PR with the use of Syntax.ChainExpression.

sanex3339 · 2020-06-16T17:21:39Z

Any news?

sanex3339 · 2020-06-20T16:27:13Z

Any ETA when this PR can be reviewed?

dilame · 2020-06-23T06:25:26Z

Hi guys! This PR is very important for me and many people in the world! Please, merge it

mikhailrojo · 2020-06-23T09:22:51Z

I upvote for fast merge

sanex3339 · 2020-06-24T18:12:36Z

@Constellation Hi. Can you check and merge this?

sanex3339 · 2020-06-26T04:27:22Z

@michaelficarra re-ping

sanex3339 · 2020-06-29T07:09:55Z

@michaelficarra re-ping

dilame · 2020-06-29T07:11:02Z

i support this re-ping

sanex3339 · 2020-07-02T06:11:08Z

@michaelficarra please, re-check this. It is REALLY hard to contribute to this project because of a lack of maintenance. It kills all motivation to contribute here.

sanex3339 · 2020-07-05T19:43:37Z

@michaelficarra re-ping

dilame · 2020-07-06T18:29:30Z

@michaelficarra re-ping

sanex3339 · 2020-07-10T07:46:12Z

@michaelficarra ping

sanex3339 · 2020-07-12T07:25:04Z

Still waiting...

sanex3339 · 2020-07-15T12:34:19Z

@michaelficarra ping

sanex3339 · 2020-07-19T05:48:06Z

@michaelficarra please check this. More than a month I'm waiting for your approval.

dilame · 2020-07-20T09:59:31Z

@michaelficarra it is insulting the feelings of contributors!

sanex3339 · 2020-08-05T19:02:38Z

@sanex3339 Please rebase.

@michaelficarra done

test/compare-acorn-es2020/optional-chaining.expected.js

…xpression callee without arguments

…ion callee without arguments

michaelficarra · 2020-08-05T23:20:42Z

Published v2.0.0 (since I got yelled at last time I dropped support for an ancient node version in a minor release).

sanex3339 · 2020-08-06T02:23:11Z

Thank you!

Co-authored-by: sanex3339 <yarabotayuvyandex3339>

Merge branch 'eslint-npm' into eslint-npm-full * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js

Merge branch 'eslint-npm' into eslint-npm-full; also fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js

Merge branch 'eslint-npm' into eslint-npm-full; also adds linting to recent adds and fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js

…recent adds and fixes regression (line 959) introduced in cf9a7b8 * eslint-npm: - npm: update estraverse - npm: update devDeps. - npm: Update package-lock version - npm: update devDeps. - npm: Update package-lock version - Linting: Temporarily disable most linting, with a few fixes - Breaking change: Remove bower-registry-client build (bower deprecated) - Update: Use new SourceMapConsumer API in test - Build: Provide browserified builds with npm package - Travis: Drop 4, 6, 8; Add 10, 12, 14; check build - Maintenance: Add `.editorconfig` - Docs: Use fenced code blocks in README (for syntax highlighting) - npm: Add `bugs`, `keywords`, change from `maintainers` to `authors`/`contributors` - npm: Restore `optionator` to a regular dep. (used in published binary file) - npm: Drop unused semver, minimist - npm: Bump deps. (estraverse, optionator, optional source-map potentially breaking) and devDeps. - npm: Drop bluebird in favor of ES Promises - npm: Use more recently maintained browserify + uglifyify - npm: Replace linting and testing scripts in Gulpfile with npm scripts Add more optional-chaining tests Test logical assignments Implement coalescing code generation Support BigInt syntax Update gulpfile and dependencies Version 2.0.0 add support for optional chaining (estools#412) Update .gitattributes drop support for node <6 (estools#419) # Conflicts: # .eslintignore # .eslintrc.js # .gitignore # escodegen.js.map # package-lock.json # package.json # src/escodegen.js # test/source-map.js # tools/release.js

sanex3339 mentioned this pull request May 30, 2020

Support optional chaining and nullish coalescing syntax javascript-obfuscator/javascript-obfuscator#604

Closed

sanex3339 changed the title ~~Optional chaining support WIP~~ Optional chaining support Jun 11, 2020

michaelficarra reviewed Jun 11, 2020

View reviewed changes

test/compare-acorn-es2020/optional-chaining.expected.js Outdated Show resolved Hide resolved

sanex3339 closed this Jun 12, 2020

sanex3339 reopened this Jun 12, 2020

sanex3339 requested a review from michaelficarra June 22, 2020 22:15

sanex3339 mentioned this pull request Jun 23, 2020

sequence as class property breaks everything javascript-obfuscator/javascript-obfuscator#638

Closed

sanex3339 mentioned this pull request Jun 23, 2020

Nullish coalescing support #417

Open

sanex3339 added 15 commits August 5, 2020 21:45

Added optional chaining support WIP

7d19ee6

Updated optional chaining support to the latest spec

7f5d20f

Updated tests to match examples from spec

97262e2

Updated tests with correct expectations

8b56419

Updated optional chaining parenthesis and added more tests

5af1f7b

Updated optional chaining support, added AST comparison tests

6e9867a

Updated Chai to version 4.2.0

c66f83d

Moved expression object flags to the variable

be2d6c6

Fixed optional CallExpression's. Added tests.

201b451

Fixed optional chaining with literal member expression object

215c838

Fixed mixed optional chaining precedence. Added more tests.

361ffd1

Simplified logic of ChainExpression precedence detection

afb6f76

Added OptionalChaining precedence and simplified logic

339e49d

Moved flags from variables to the calls

2782a3e

Added tests with optional chaining as a part of NewExpression callee

f672353

sanex3339 force-pushed the optional-chaining-support branch from 4cce5f8 to f672353 Compare August 5, 2020 19:01

michaelficarra reviewed Aug 5, 2020

View reviewed changes

test/compare-acorn-es2020/optional-chaining.expected.js Show resolved Hide resolved

sanex3339 added 2 commits August 5, 2020 23:46

Removed redundant trailing parenthesis from NewExpression with ChainE…

8f05fb0

…xpression callee without arguments

Reverted logic to keep parenthesis of NewExpression with ChainExpress…

eb9cbb0

…ion callee without arguments

michaelficarra approved these changes Aug 5, 2020

View reviewed changes

michaelficarra changed the title ~~Optional chaining support~~ add support for optional chaining Aug 5, 2020

michaelficarra merged commit 1d192ae into estools:master Aug 5, 2020

sanex3339 added a commit to javascript-obfuscator/escodegen that referenced this pull request Aug 14, 2020

add support for optional chaining (estools#412)

2ebed24

Co-authored-by: sanex3339 <yarabotayuvyandex3339>

Conversation

sanex3339 commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanex3339 commented Jun 11, 2020

Uh oh!

sanex3339 commented Jun 11, 2020

Uh oh!

sanex3339 commented Jun 11, 2020

Uh oh!

Uh oh!

sanex3339 commented Jun 12, 2020

Uh oh!

sanex3339 commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanex3339 commented Jun 13, 2020

Uh oh!

sanex3339 commented Jun 16, 2020

Uh oh!

sanex3339 commented Jun 20, 2020

Uh oh!

dilame commented Jun 23, 2020

Uh oh!

mikhailrojo commented Jun 23, 2020

Uh oh!

sanex3339 commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanex3339 commented Jun 26, 2020

Uh oh!

sanex3339 commented Jun 29, 2020

Uh oh!

dilame commented Jun 29, 2020

Uh oh!

sanex3339 commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanex3339 commented Jul 5, 2020

Uh oh!

dilame commented Jul 6, 2020

Uh oh!

sanex3339 commented Jul 10, 2020

Uh oh!

sanex3339 commented Jul 12, 2020

Uh oh!

sanex3339 commented Jul 15, 2020

Uh oh!

sanex3339 commented Jul 19, 2020

Uh oh!

dilame commented Jul 20, 2020

Uh oh!

sanex3339 commented Aug 5, 2020

Uh oh!

Uh oh!

michaelficarra commented Aug 5, 2020

Uh oh!

sanex3339 commented Aug 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sanex3339 commented May 30, 2020 •

edited

Loading

sanex3339 commented Jun 12, 2020 •

edited

Loading

sanex3339 commented Jun 24, 2020 •

edited

Loading

sanex3339 commented Jul 2, 2020 •

edited

Loading