Skip to content

Nullish coalescing support#417

Open
sanex3339 wants to merge 4 commits intoestools:masterfrom
javascript-obfuscator:nullish-coalescing-support
Open

Nullish coalescing support#417
sanex3339 wants to merge 4 commits intoestools:masterfrom
javascript-obfuscator:nullish-coalescing-support

Conversation

@sanex3339
Copy link
Contributor

@sanex3339 sanex3339 commented Jun 23, 2020 •
edited
Loading

I have no idea what I'm doing but it works.
Probably it can be done in a more simple way.

@sanex3339 sanex3339 changed the base branch from sanex3339-exponentiation-operator to master June 23, 2020 20:19
@sanex3339 sanex3339 mentioned this pull request Jul 7, 2020
Closed
@sanex3339 sanex3339 mentioned this pull request Jul 23, 2020
Merged
@sanex3339 sanex3339 force-pushed the nullish-coalescing-support branch from 3ea3706 to 121f9a8 Compare August 6, 2020 06:04
@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 6, 2020 •
edited
Loading

@bakkot, @michaelficarra Now let's do this!

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 14, 2020

Looks like this one will take a bunch of the time too =(

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 15, 2020 •
edited
Loading

@bakkot may you review this please? It would be nice to get this in good form before @michaelficarra see this.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 20, 2020

@michaelficarra any news?

@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 22, 2020 •
edited
Loading

And again two months have passed since the PR was created and still no response =(

bakkot
bakkot reviewed Aug 24, 2020
View reviewed changes
@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 24, 2020

@bakkot thank you, i updated the PR:
5646f11

bakkot
bakkot reviewed Aug 24, 2020
View reviewed changes
@sanex3339
Copy link
Contributor Author

sanex3339 commented Aug 25, 2020

@michaelficarra may you check it now?

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 1, 2020

@michaelficarra ping. Please check this.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 12, 2020

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 17, 2020

@michaelficarra this PR is still here. 3 months have left since it was created.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 23, 2020 •
edited
Loading

@michaelficarra @Constellation ping
Let's celebrate the 3rd month that is passed without any attention to this PR.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Sep 28, 2020

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 2, 2020

@michaelficarra please check this

@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 7, 2020

@michaelficarra ping

1 similar comment
@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 12, 2020

@michaelficarra ping

@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 17, 2020

Seems it's definitely the time to create a fork.

@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 20, 2020

@michaelficarra Ping

@sanex3339
Copy link
Contributor Author

sanex3339 commented Oct 31, 2020

@michaelficarra last ping in hope that it will be merged and I wont create a fork with all my PRs

This was referenced Oct 31, 2020
Closed
Closed
@sanex3339
Copy link
Contributor Author

sanex3339 commented Nov 4, 2020

I created the fork with this feature:
https://www.npmjs.com/package/@javascript-obfuscator/escodegen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bakkot bakkot bakkot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanex3339 @bakkot