Skip to content

feat: temporary error message [ENG-2515]#7314

Merged
speaker-ender merged 3 commits intomainfrom
feat/temporary-error-message--ENG-2515
Feb 5, 2026
Merged

feat: temporary error message [ENG-2515]#7314
speaker-ender merged 3 commits intomainfrom
feat/temporary-error-message--ENG-2515

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 4, 2026

Ticket ENG-2515

Description Of Changes

Adding a more descriptive error message for 403 actions attempted in the monitor fields screen

Code Changes

Steps to Confirm

  1. Create a user with viewer permissions
  2. Log in as that user
  3. Go to the action center screen
  4. Attempt to perform all actions
  5. Confirm that error messages contain more descriptive error message for permission

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 5, 2026 4:15pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 5, 2026 4:15pm

Request Review

@speaker-ender speaker-ender marked this pull request as ready for review February 4, 2026 22:18
@speaker-ender speaker-ender requested a review from a team as a code owner February 4, 2026 22:18
@speaker-ender speaker-ender requested review from jpople and removed request for a team February 4, 2026 22:18
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

This PR improves error messaging for permission-denied (403) errors in the monitor fields action center by detecting 403 status codes and displaying "Action failed: insufficient permissions to perform action" instead of generic error messages.

Changes:

  • Modified getActionErrorMessage to accept an optional reason parameter
  • Added 403 error detection logic in useBulkActions.tsx and useFieldActions.tsx
  • Removed action-type-specific error message logic (activity tab suffix for classify/promote actions)

Issues Found:

  • useConfirmAllFields.tsx still uses the old getActionErrorMessage(actionType) signature and won't receive the updated 403 error messaging
  • Comment formatting inconsistency between the two hook files
  • Minor syntax error in comment format

Confidence Score: 3/5

  • This PR is generally safe to merge but has one critical issue with incomplete implementation
  • The changes improve user experience by providing clearer error messages for permission errors. However, useConfirmAllFields.tsx was not updated to use the new error message signature, creating inconsistent behavior. The implementation is straightforward but incomplete.
  • useConfirmAllFields.tsx needs to be updated to match the new getActionErrorMessage signature for consistent 403 error handling

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/useBulkActions.tsx Added 403 error handling to provide permission-specific error messages for bulk actions
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/useFieldActions.tsx Added 403 error handling to provide permission-specific error messages for field actions
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts Refactored getActionErrorMessage to accept an optional reason parameter, removing action-type-specific logic

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Additional Comments (1)

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/useFieldActions.tsx
useConfirmAllFields.tsx at line 63 still uses the old getActionErrorMessage(actionType) signature and won't get the updated 403 error messaging. Needs updating for consistency.

@speaker-ender speaker-ender force-pushed the feat/temporary-error-message--ENG-2515 branch from cc7c49f to 5e813e6 Compare February 5, 2026 15:16
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working for me on datastore monitors. Should we apply this in useInfrastructureSystemsBulkActions as well? With an Okta monitor you still get the error message directly from the backend.

Image

@speaker-ender
Copy link
Contributor Author

Tested locally, working for me on datastore monitors. Should we apply this in useInfrastructureSystemsBulkActions as well? With an Okta monitor you still get the error message directly from the backend.

Image

@jpople
Good callout.
Ideally they should be the same.
There are a lot of inconsistencies at the moment that I'd like to align between those two screens.
I can do that here if you'd like, but I think the end goal is to not have this error at all

@jpople
Copy link
Contributor

jpople commented Feb 5, 2026

@speaker-ender If this is something that's going away soon I'm not too worried about it then, LGTM.

@speaker-ender speaker-ender added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 02303e5 Feb 5, 2026
46 checks passed
@speaker-ender speaker-ender deleted the feat/temporary-error-message--ENG-2515 branch February 5, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants