Skip to content

feat: temporary error message [ENG-2515] #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
speaker-ender merged 3 commits into from
Feb 5, 2026
Merged

feat: temporary error message [ENG-2515] #7314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e877a8e
feat: temporary error message [ENG-2515]
speaker-ender Feb 4, 2026
5e813e6
chore: added changelog
speaker-ender Feb 4, 2026
f873ef1
Merge branch 'main' into feat/temporary-error-message--ENG-2515
speaker-ender Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/7314.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Copy this file and rename it (e.g., pr-number.yaml or feature-name.yaml)
# Fill in the required fields and delete this comment block

type: Added # One of: Added, Changed, Developer Experience, Deprecated, Docs, Fixed, Removed, Security
description: More descriptive error message for unauthorized actions in action center
pr: 7314 # PR number
labels: [] # Optional: ["high-risk", "db-migration"]

10 changes: 9 additions & 1 deletion ...dmin-ui/src/features/data-discovery-and-detection/action-center/fields/useBulkActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,18 @@ export const useBulkActions = (
});

if (isErrorResult(mutationResult)) {
/** Our error messages are bad. Purposefully out of place * */
Comment thread
speaker-ender marked this conversation as resolved.
const errorReason =
"error" in mutationResult &&
"status" in mutationResult.error &&
mutationResult.error.status === 403
? "insufficient permissions to perform action"
: "";

messageApi.open({
key,
type: "error",
content: getActionErrorMessage(actionType),
content: getActionErrorMessage(errorReason),
duration: 5,
});

Expand Down
10 changes: 9 additions & 1 deletion ...min-ui/src/features/data-discovery-and-detection/action-center/fields/useFieldActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,18 @@ export const useFieldActions = (
const result = await mutationFn(urns, field);

if (isErrorResult(result)) {
/** Our error messages are bad. * */
Comment thread
speaker-ender marked this conversation as resolved.
const errorReason =
"error" in result &&
"status" in result.error &&
result.error.status === 403
? "insufficient permissions to perform action"
: "";

messageApi.open({
key,
type: "error",
content: getActionErrorMessage(actionType),
content: getActionErrorMessage(errorReason),
duration: 5,
});
return;
Expand Down
10 changes: 2 additions & 8 deletions clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,8 @@ export const getActionSuccessMessage = (
) =>
`${FIELD_ACTION_COMPLETED[actionType]}${pluralize(itemCount ?? 0, "", `${actionType === FieldActionType.ASSIGN_CATEGORIES ? " for" : ""} ${itemCount?.toLocaleString()} resources`)}`;

export const getActionErrorMessage = (actionType: FieldActionType) => {
const activityTabSuffix =
actionType === FieldActionType.CLASSIFY ||
actionType === FieldActionType.PROMOTE
? ": View summary in the activity tab"
: "";
return `Action failed${activityTabSuffix}`;
};
export const getActionErrorMessage = (reason?: string) =>
[`Action failed`, ...(reason ? [reason] : [])].join(": ");
Comment thread
speaker-ender marked this conversation as resolved.

const CONFIDENCE_BUCKET_TO_SEVERITY: Record<
ConfidenceBucket,
Expand Down
Loading