docs(cli): make Slider/Selector/MultiSelector showcases interactive#3199
Open
durvesh1992 wants to merge 1 commit into
Open
docs(cli): make Slider/Selector/MultiSelector showcases interactive#3199durvesh1992 wants to merge 1 commit into
durvesh1992 wants to merge 1 commit into
Conversation
Closes facebook#3187. Closes facebook#3188. Closes facebook#3189. These showcase blocks rendered controlled components with a static value and a no-op/missing onChange, so the docsite previews appeared frozen (dragging the slider / picking an option did nothing). Wire local useState + onChange in each, mirroring the other examples (SliderWithMarks, SelectorWithSections, MultiSelectorColumnVisibilitySelector). MultiSelectorShowcase also gains 'use client' now that it uses state.
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3187. Closes #3188. Closes #3189.
The Slider, Selector, and MultiSelector showcase blocks rendered controlled components with a static
valueand a no-op/missingonChange, so the docsite previews appeared frozen — dragging the slider or picking an option did nothing. Wired localuseState+onChangein each, mirroring the existing examples that already do this (SliderWithMarks,SelectorWithSections,MultiSelectorColumnVisibilitySelector).Slider/SliderShowcase.tsx—useState(50)+onChangeSelector/SelectorShowcase.tsx—useState<string | undefined>()+value/onChangeMultiSelector/MultiSelectorShowcase.tsx—useState<string[]>([])+onChange; added'use client'(now uses state)Testing
Changeset
Included (
@astryxdesign/clipatch) — showcase blocks ship incli/templates.