fix(auth): preserve linkDomain in email link ActionCodeSettings#2321
Merged
Conversation
demolaf
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that the linkDomain property is preserved when generating ActionCodeSettings within the AuthProvider class, supported by a new unit test. The reviewer suggested also including the deprecated dynamicLinkDomain property to maintain backward compatibility for existing projects.
russellwheatley
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1730
When sending an email sign-in link, addSessionInfoToActionCodeSettings rebuilt the ActionCodeSettings without forwarding linkDomain, so custom domains were silently ignored and the default project domain was always used instead. This adds linkDomain to the rebuilt settings and a regression test to cover it.