Skip to content

fix(auth): preserve linkDomain in email link ActionCodeSettings #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
russellwheatley merged 1 commit into from
May 15, 2026
Merged

fix(auth): preserve linkDomain in email link ActionCodeSettings #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions auth/src/main/java/com/firebase/ui/auth/configuration/auth_provider/AuthProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ abstract class AuthProvider(open val providerId: String, open val providerName:
return actionCodeSettings {
url = continueUrl
handleCodeInApp = emailLinkActionCodeSettings.canHandleCodeInApp()
linkDomain = emailLinkActionCodeSettings.linkDomain
Comment thread
demolaf marked this conversation as resolved.
iosBundleId = emailLinkActionCodeSettings.iosBundle
setAndroidPackageName(
emailLinkActionCodeSettings.androidPackageName ?: "",
Expand Down
23 changes: 23 additions & 0 deletions auth/src/test/java/com/firebase/ui/auth/configuration/auth_provider/AuthProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,29 @@ class AuthProviderTest {
// Email Provider Tests
// =============================================================================================

@Test
fun `addSessionInfoToActionCodeSettings preserves linkDomain`() {
val actionCodeSettings = actionCodeSettings {
url = "https://example.com"
handleCodeInApp = true
linkDomain = "myapp.page.link"
setAndroidPackageName("com.example", true, null)
}

val provider = AuthProvider.Email(
isEmailLinkSignInEnabled = true,
emailLinkActionCodeSettings = actionCodeSettings,
passwordValidationRules = emptyList()
)

val result = provider.addSessionInfoToActionCodeSettings(
sessionId = "abc123",
anonymousUserId = ""
)

assertThat(result.linkDomain).isEqualTo("myapp.page.link")
}

@Test
fun `email provider with valid configuration should succeed`() {
val provider = AuthProvider.Email(
Expand Down
Loading