Fix missing const#46
Closed
juliandescottes wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Linter and CI are on #47 for reference |
Member
Author
|
Closing, let's just have one PR #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
I introduced a bug during the review cycle, and it wasn't caught by the test, not sure why yet. Maybe slightly different environment which allows properties on globals to be automatically created?
Also taking the opportunity to remove a
Promise.withResolverswhich could be incompatible with the earliest node versions supported by BrowserTime.Will add linter and CI in another PR.