Fix missing const, add linter and CI#47
Merged
Merged
Conversation
juliandescottes
force-pushed
the
linter-ci
branch
2 times, most recently
from
2a148a0 to
8c412a0
Compare
Closed
juliandescottes
force-pushed
the
linter-ci
branch
from
8c412a0 to
9a1b848
Compare
Add dependency to eslint and basic configuration for node and jest. Adds two npm scripts to run eslint "lint" and "lint:fix"
This commit fixes all the remaining linter issues except the ones already handled in another PR
juliandescottes
force-pushed
the
linter-ci
branch
from
9a1b848 to
a1054d4
Compare
juliandescottes
changed the title
whimboo
approved these changes
Jan 23, 2026
Contributor
whimboo
left a comment
whimboo
left a comment
There was a problem hiding this comment.
Generally looks fine. Good to see the addition of the workflow.
I would only like to see updates regarding the two inline comments regarding versions.
Basic github ci workflow to run tests and linting in automation
juliandescottes
force-pushed
the
linter-ci
branch
from
a1054d4 to
c61b605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45