fix: tform: potential crash due to race when MODMAX/MODMIN#797
Open
jodavies wants to merge 1 commit intoform-dev:masterfrom
Open
fix: tform: potential crash due to race when MODMAX/MODMIN#797jodavies wants to merge 1 commit intoform-dev:masterfrom
jodavies wants to merge 1 commit intoform-dev:masterfrom
Conversation
A worker could free a dollar variable's data, while another worker is trying to read it. Lock the dollar variable before working out its RHS in case the RHS depends on the dollar variable that is being assigned.
Collaborator
|
I wonder if the CI failure might be related to awalsh128/cache-apt-pkgs-action#187. When I print the Valgrind errors, it seems like it could be a libc6-dbg incompatibility(?): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker could free a dollar variable's data, while another worker is trying to read it. Lock the dollar variable before working out its RHS in case the RHS depends on the dollar variable that is being assigned.
This closes #147 and #796 , though #796 contains more discussion for the future.