Skip to content

fix: tform: potential crash due to race when MODMAX/MODMIN #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jodavies wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: tform: potential crash due to race when MODMAX/MODMIN #797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions sources/dollar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,14 +394,11 @@ NoChangeOne:;
}
/*
Now the real evaluation.
In the case of threads and MODSUM this requires an immediate lock.
Otherwise the lock could be placed later.
We need to lock here before we work out the RHS, in case the RHS itself
depends on the dollar variable.
*/
#ifdef WITHPTHREADS
if ( dtype == MODSUM ) {
/* LOCK(d->pthreadslockwrite); */
LOCK(d->pthreadslockread);
}
LOCK(d->pthreadslockread);
#endif
CleanDollarFactors(d);
/*
Expand Down Expand Up @@ -445,12 +442,7 @@ NoChangeOne:;
}
numterms = 0; t = ss; while ( *t ) { numterms++; t += *t; }
}
#ifdef WITHPTHREADS
if ( dtype != MODSUM ) {
/* LOCK(d->pthreadslockwrite); */
LOCK(d->pthreadslockread);
}
#endif

if ( numterms == 0 ) {
/*
the new value evaluates to zero
Expand Down
Loading