feat(action-log): Route recovery through dedicated outbox - #121985
Draft
cvxluo wants to merge 2 commits into
Draft
feat(action-log): Route recovery through dedicated outbox#121985cvxluo wants to merge 2 commits into
cvxluo wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
Scope: Backend
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
cvxluo
force-pushed
the
cvxluo/route-recovery-through-dedicated-outbox
branch
from
August 13, 2026 19:03
d4ff75a to
7e0b2f0
Compare
kcons
reviewed
Aug 13, 2026
| if not write_to_db: | ||
| return | ||
|
|
||
| use_dedicated_outbox = options.get("issues.action_log.use_dedicated_outbox") |
Member
There was a problem hiding this comment.
I think we wantto use a group-keyed in_rollout_group in here. If this is broken and we turn it on for 100% of US, we break lots of things. Better to turn it on for a sampling of groups, and scale up once nothing has failed.
|
|
||
| use_dedicated_outbox = options.get("issues.action_log.use_dedicated_outbox") | ||
| outbox_model = GroupActionLogOutbox if use_dedicated_outbox else CellOutbox | ||
| metrics.incr( |
Member
There was a problem hiding this comment.
wouldn't be unreasonable to include this in issues.action_log. the no-write case could be unset or what we would set, not sure which I prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.