feat: API configuration: 20260512T090125Z#15615
Conversation
google-cloud-sdk-librarian-dotnet-robot
requested a review
from a team
as a code owner
|
Pull request diff results |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the configuration for the Google.Backstory API to the generator input and pipeline state. The review feedback identifies two consistency and branding issues: the use of an internal codename in the product name and a deviation from the standard Google.Cloud naming convention for the API ID.
| "id": "Google.Backstory", | ||
| "version": "1.0.0-beta00", | ||
| "type": "grpc", | ||
| "productName": "Malachite Common Protos", |
There was a problem hiding this comment.
The productName "Malachite Common Protos" uses an internal codename ("Malachite"). This should be updated to a public-facing name such as "Chronicle Common Protos" or "Google Security Operations Common Protos" to align with the product's public branding and the provided productUrl.
| "productName": "Malachite Common Protos", | |
| "productName": "Chronicle Common Protos", |
| "includeCommonResourcesProto": true | ||
| }, | ||
| { | ||
| "id": "Google.Backstory", |
There was a problem hiding this comment.
The id "Google.Backstory" deviates from the standard Google.Cloud.{Service} naming convention used for other libraries in this configuration (e.g., Google.Cloud.AccessApproval.V1). To maintain consistency with the repository's naming standards for Cloud APIs, consider using Google.Cloud.Backstory.
2 participants
Changes in this PR