Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions generator-input/apis.json
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,21 @@
"transport": "grpc+rest",
"includeCommonResourcesProto": true
},
{
"id": "Google.Backstory",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The id "Google.Backstory" deviates from the standard Google.Cloud.{Service} naming convention used for other libraries in this configuration (e.g., Google.Cloud.AccessApproval.V1). To maintain consistency with the repository's naming standards for Cloud APIs, consider using Google.Cloud.Backstory.

"version": "1.0.0-beta00",
"type": "grpc",
"productName": "Malachite Common Protos",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The productName "Malachite Common Protos" uses an internal codename ("Malachite"). This should be updated to a public-facing name such as "Chronicle Common Protos" or "Google Security Operations Common Protos" to align with the product's public branding and the provided productUrl.

Suggested change
"productName": "Malachite Common Protos",
"productName": "Chronicle Common Protos",

"productUrl": "https://cloud.google.com/chronicle/docs/secops/secops-overview",
"description": "Common Universal Data Model (UDM) and Entity protos used by Chronicle.",
"tags": [],
"dependencies": {},
"generator": "micro",
"protoPath": "backstory",
"shortName": "backstory",
"serviceConfigFile": "backstory.yaml",
"restNumericEnums": false
},
{
"id": "Google.Cloud.AccessApproval.V1",
"version": "2.6.0",
Expand Down
12 changes: 12 additions & 0 deletions generator-input/pipeline-state.json
Original file line number Diff line number Diff line change
Expand Up @@ -5043,6 +5043,18 @@
"sourcePaths": [
"apis/Google.Cloud.GeminiDataAnalytics.V1/Google.Cloud.GeminiDataAnalytics.V1"
]
},
{
"id": "Google.Backstory",
"nextVersion": "1.0.0-beta01",
"generationAutomationLevel": "AUTOMATION_LEVEL_AUTOMATIC",
"releaseAutomationLevel": "AUTOMATION_LEVEL_BLOCKED",
"apiPaths": [
"backstory"
],
"sourcePaths": [
"apis/Google.Backstory/Google.Backstory"
]
}
],
"ignoredApiPaths": [
Expand Down
Loading