Merged
Conversation
Currently the poetry detection only accounts for the presence of a pyproject.toml file which nowadays is used by many other build backends. The detection now checks whether the file contains the corresponding build-system entry or no entry which matches the poetry v1 implementation. This should result in backward compatible behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR implements smarter handling of the
pyproject.tomlfile during the poetry detection.Currently if that file existence is the only condition for providing poetry.
The refactor adds a check for the content of the file so that if a different build system is used, poetry will not be provided.
The detection is done so that both old and new projects shall be handled without incompatibility.
Basically:
poetry.core.masonry.api## Ticket links and issues
Fixes #48