Skip to content

i40e: report VF xx still in reset when set VF's vlanid #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaozhengwei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

i40e: report VF xx still in reset when set VF's vlanid #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/i40e_virtchnl_pf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6081,6 +6081,7 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev,
struct i40e_vf *vf;
__le16 *pvid;
int ret;
int i;

if (test_and_set_bit(__I40E_VIRTCHNL_OP_PENDING, pf->state)) {
dev_warn(&pf->pdev->dev, "Unable to configure VFs, other operation is pending.\n");
Expand All @@ -6107,6 +6108,20 @@ int i40e_ndo_set_vf_port_vlan(struct net_device *netdev,
#endif

vf = &pf->vf[vf_id];
/* When the VF is resetting wait until it is done.
* It can take up to 200 milliseconds,
* but wait for up to 300 milliseconds to be safe.
* Acquire the vsi pointer only after the VF has been
* properly initialized.
*/
netdev_info(netdev, "Setting VF %d vlan %d\n", vf_id, vlan_id);
for (i = 0; i < 15; i++) {
if (test_bit(I40E_VF_STATE_INIT, &vf->vf_states))
break;
dev_info(&pf->pdev->dev, "VF %d is resetting when set vlan.\n",
vf_id);
msleep(20);
}
vsi = pf->vsi[vf->lan_vsi_idx];
if (!test_bit(I40E_VF_STATE_INIT, &vf->vf_states)) {
dev_err(&pf->pdev->dev, "VF %d still in reset. Try again.\n",
Expand Down