Skip to content

fix(cli): make tests OS-agnostic by normalizing path separators #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukund-2114 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): make tests OS-agnostic by normalizing path separators #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-melons-sin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"lingo.dev": patch
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name in the changeset should be '@lingo.dev/cli' or similar, not 'lingo.dev'. The changeset should reference the actual package being changed (the CLI package), not the root project name.

Suggested change
"lingo.dev": patch
"@lingo.dev/cli": patch

Copilot uses AI. Check for mistakes.
---

fix(cli): normalize path separators in tests for Windows
1 change: 1 addition & 0 deletions lingo.dev
Open in desktop
Submodule lingo.dev added at 060680
15 changes: 11 additions & 4 deletions packages/cli/src/cli/utils/buckets.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ describe("getBuckets", () => {
},
});

const toPosix = (s: string) => s.replace(/\\/g, "/");
const normalizeBuckets = (buckets: any) =>
buckets.map((b: any) => ({
type: b.type,
paths: b.paths.map((p: any) => ({ ...p, pathPattern: toPosix(p.pathPattern) })),
}));

it("should return correct buckets", () => {
mockGlobSync(["src/i18n/en.json"], ["src/translations/en/messages.json"]);

Expand All @@ -31,7 +38,7 @@ describe("getBuckets", () => {
"src/translations/[locale]/messages.json",
]);
const buckets = getBuckets(i18nConfig);
expect(buckets).toEqual([
expect(normalizeBuckets(buckets)).toEqual([
{
type: "json",
paths: [
Expand Down Expand Up @@ -76,7 +83,7 @@ describe("getBuckets", () => {
"src/i18n/data-*-[locale]-*/[locale].*.json",
]);
const buckets = getBuckets(i18nConfig);
expect(buckets).toEqual([
expect(normalizeBuckets(buckets)).toEqual([
{
type: "json",
paths: [
Expand Down Expand Up @@ -136,7 +143,7 @@ describe("getBuckets", () => {
{ path: "src/i18n/[locale].json", delimiter: "-" },
]);
const buckets = getBuckets(i18nConfig);
expect(buckets).toEqual([
expect(normalizeBuckets(buckets)).toEqual([
{
type: "json",
paths: [{ pathPattern: "src/i18n/[locale].json", delimiter: "-" }],
Expand All @@ -154,7 +161,7 @@ describe("getBuckets", () => {
"src/[locale]/translations/[locale]/messages.json",
]);
const buckets = getBuckets(i18nConfig);
expect(buckets).toEqual([
expect(normalizeBuckets(buckets)).toEqual([
{
type: "json",
paths: [
Expand Down
15 changes: 11 additions & 4 deletions packages/cli/src/cli/utils/find-locale-paths.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ describe("findLocaleFiles", () => {
vi.clearAllMocks();
});

const toPosix = (s: string) => s.replace(/\\/g, "/");
const normalize = (r: { patterns: string[]; defaultPatterns: string[] } | null) =>
r && {
patterns: r.patterns.map(toPosix),
defaultPatterns: r.defaultPatterns.map(toPosix),
};

it("should find json locale files", () => {
vi.mocked(glob.sync).mockReturnValue([
// valid locales
Expand All @@ -26,7 +33,7 @@ describe("findLocaleFiles", () => {
"src/settings.json",
]);

const result = findLocaleFiles("json");
const result = normalize(findLocaleFiles("json"));

expect(result).toEqual({
patterns: ["src/i18n/[locale].json", "src/translations/[locale].json"],
Expand All @@ -41,7 +48,7 @@ describe("findLocaleFiles", () => {
"translations/es.yml",
]);

const result = findLocaleFiles("yaml");
const result = normalize(findLocaleFiles("yaml"));

expect(result).toEqual({
patterns: ["locales/[locale].yml", "translations/[locale].yml"],
Expand All @@ -56,7 +63,7 @@ describe("findLocaleFiles", () => {
"lib/translations/fr.arb",
]);

const result = findLocaleFiles("flutter");
const result = normalize(findLocaleFiles("flutter"));

expect(result).toEqual({
patterns: ["lib/l10n/[locale].arb", "lib/translations/[locale].arb"],
Expand Down Expand Up @@ -124,7 +131,7 @@ describe("findLocaleFiles", () => {
"ios/MyApp/xx/Localizable.xcstrings",
]);

const result = findLocaleFiles("xcode-xcstrings");
const result = normalize(findLocaleFiles("xcode-xcstrings"));

expect(result).toEqual({
patterns: [
Expand Down
Loading