Skip to content

fix: rust-quick-xml0.38: fix upstream-name to match component name#16486

Merged
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-quick-xml0.38
Apr 7, 2026
Merged

fix: rust-quick-xml0.38: fix upstream-name to match component name#16486
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-quick-xml0.38

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 7, 2026

rust-quick-xml0.38: fix upstream-name to match component name

koji/taskinfo?taskID=1128250
closed buildSRPMFromSCM (/microsoft/azurelinux.git:7e2e9732869f4ff0a0370999e08909aa192accb7)
closed buildArch (rust-quick-xml0.38-0.38.4-1.azl4bootstrap.20260405.src.rpm, x86_64)
closed buildArch (rust-quick-xml0.38-0.38.4-1.azl4
bootstrap.20260405.src.rpm, aarch64)

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Copilot AI review requested due to automatic review settings April 7, 2026 03:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the component definition for rust-quick-xml0.38 to adjust the pinned Fedora 43 upstream spec reference, aiming to align upstream-name/pinning with the intended upstream package source.

Changes:

  • Update spec.upstream-name for rust-quick-xml0.38.
  • Update the pinned Fedora dist-git upstream-commit for the component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned upstream-commit was updated, but the surrounding comment doesn’t include a reference URL to the Fedora dist-git commit that this pin tracks. Please add a full link (e.g., https://src.fedoraproject.org/rpms//c/) so future readers can verify why this exact commit is needed and when it can be dropped (the TODO mentions that but the source isn’t cited).

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package:
# https://src.fedoraproject.org/rpms/rust-quick-xml0.38/c/d94a78960d1a8a514691581d14bb75d9f8f9f7f1

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "592f13a068e585f78e5a3a1c5277eb9a7ed47cfd" }
spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream-name is now set to rust-quick-xml0.38, which matches the component name. In most similar version-suffixed Rust components, upstream-name points to the Fedora dist-git package name without the version suffix (e.g., rust-cssparser0.31 uses upstream-name rust-cssparser; rust-string_cache0.8 uses rust-string_cache). Please confirm the actual dist-git repo name for this package: if it’s also rust-quick-xml0.38, you can omit upstream-name entirely (it’s redundant); if it’s rust-quick-xml, keep upstream-name = "rust-quick-xml" to avoid fetching the wrong spec.

Suggested change
spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }
spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }

Copilot uses AI. Check for mistakes.
@christopherco christopherco merged commit bb8811a into tomls/base/main Apr 7, 2026
9 checks passed
@christopherco christopherco deleted the bphilip/rust-quick-xml0.38 branch April 7, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants