fix: rust-quick-xml0.38: fix upstream-name to match component name#16486
fix: rust-quick-xml0.38: fix upstream-name to match component name#16486christopherco merged 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the component definition for rust-quick-xml0.38 to adjust the pinned Fedora 43 upstream spec reference, aiming to align upstream-name/pinning with the intended upstream package source.
Changes:
- Update
spec.upstream-nameforrust-quick-xml0.38. - Update the pinned Fedora dist-git
upstream-commitfor the component.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,4 +2,4 @@ | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
The pinned upstream-commit was updated, but the surrounding comment doesn’t include a reference URL to the Fedora dist-git commit that this pin tracks. Please add a full link (e.g., https://src.fedoraproject.org/rpms//c/) so future readers can verify why this exact commit is needed and when it can be dropped (the TODO mentions that but the source isn’t cited).
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package: | |
| # https://src.fedoraproject.org/rpms/rust-quick-xml0.38/c/d94a78960d1a8a514691581d14bb75d9f8f9f7f1 |
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "592f13a068e585f78e5a3a1c5277eb9a7ed47cfd" } | ||
| spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" } |
There was a problem hiding this comment.
upstream-name is now set to rust-quick-xml0.38, which matches the component name. In most similar version-suffixed Rust components, upstream-name points to the Fedora dist-git package name without the version suffix (e.g., rust-cssparser0.31 uses upstream-name rust-cssparser; rust-string_cache0.8 uses rust-string_cache). Please confirm the actual dist-git repo name for this package: if it’s also rust-quick-xml0.38, you can omit upstream-name entirely (it’s redundant); if it’s rust-quick-xml, keep upstream-name = "rust-quick-xml" to avoid fetching the wrong spec.
| spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" } | |
| spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" } |
rust-quick-xml0.38: fix upstream-name to match component name
koji/taskinfo?taskID=1128250
closed buildSRPMFromSCM (/microsoft/azurelinux.git:7e2e9732869f4ff0a0370999e08909aa192accb7)
closed buildArch (rust-quick-xml0.38-0.38.4-1.azl4
bootstrap.20260405.src.rpm, x86_64)bootstrap.20260405.src.rpm, aarch64)closed buildArch (rust-quick-xml0.38-0.38.4-1.azl4
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology