Skip to content

fix: rust-quick-xml0.38: fix upstream-name to match component name #16486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 7, 2026
+1 −1
Merged

fix: rust-quick-xml0.38: fix upstream-name to match component name #16486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/comps/rust-quick-xml0.38/rust-quick-xml0.38.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pinned upstream-commit was updated, but the surrounding comment doesn’t include a reference URL to the Fedora dist-git commit that this pin tracks. Please add a full link (e.g., https://src.fedoraproject.org/rpms//c/) so future readers can verify why this exact commit is needed and when it can be dropped (the TODO mentions that but the source isn’t cited).

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package:
# https://src.fedoraproject.org/rpms/rust-quick-xml0.38/c/d94a78960d1a8a514691581d14bb75d9f8f9f7f1

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "592f13a068e585f78e5a3a1c5277eb9a7ed47cfd" }
spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream-name is now set to rust-quick-xml0.38, which matches the component name. In most similar version-suffixed Rust components, upstream-name points to the Fedora dist-git package name without the version suffix (e.g., rust-cssparser0.31 uses upstream-name rust-cssparser; rust-string_cache0.8 uses rust-string_cache). Please confirm the actual dist-git repo name for this package: if it’s also rust-quick-xml0.38, you can omit upstream-name entirely (it’s redundant); if it’s rust-quick-xml, keep upstream-name = "rust-quick-xml" to avoid fetching the wrong spec.

Suggested change
spec = { type = "upstream", upstream-name = "rust-quick-xml0.38", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }
spec = { type = "upstream", upstream-name = "rust-quick-xml", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d94a78960d1a8a514691581d14bb75d9f8f9f7f1" }

Copilot uses AI. Check for mistakes.
Loading