fix: rust-miniz_oxide0.8: fix upstream-name to match component name#16489
fix: rust-miniz_oxide0.8: fix upstream-name to match component name#16489christopherco merged 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the component definition for rust-miniz_oxide0.8 to adjust how the Fedora upstream spec source is referenced, aligning with the intent to fetch the correct upstream dist-git content for Azure Linux’s Rust crate packaging.
Changes:
- Update
spec.upstream-nameforrust-miniz_oxide0.8. - Update the pinned
spec.upstream-commithash for Fedora 43.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,4 +2,4 @@ | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
This component is pinned via upstream-commit, but the surrounding comment block doesn’t include a reference link to the upstream dist-git commit (and the pinned commit changed in this PR). Per the comp-toml instructions’ References guidance, please add a full URL to the Fedora src.fedoraproject.org commit (and keep the existing TODO/exit condition) so future readers can audit why/when this pin can be dropped.
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-miniz_oxide0.8/c/809f44a243e41106d276040d42cedc618ed5401b |
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-miniz_oxide", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "6ff8fbdccbe6b185546f42a70fd93664c3976899" } | ||
| spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" } |
There was a problem hiding this comment.
spec.upstream-name is intended to override the upstream (Fedora) component name only when it differs from the local component name. After this change it’s identical to the component (rust-miniz_oxide0.8), so it’s redundant and may confuse future readers about whether a rename/mapping is happening. Consider removing upstream-name entirely unless it’s required for a specific tooling reason.
| spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" } | |
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" } |
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-miniz_oxide", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "6ff8fbdccbe6b185546f42a70fd93664c3976899" } | ||
| spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" } |
There was a problem hiding this comment.
The PR title/summary indicates an upstream-name fix, but this change also updates the pinned upstream-commit. If the commit change is intentional (e.g., to track the correct dist-git repo/branch for the new upstream-name), please reflect that in the PR description/title so reviewers understand this is also a pin update.
rust-miniz_oxide0.8: fix upstream-name to match component name
koji/taskinfo?taskID=1128265
closed buildSRPMFromSCM (/microsoft/azurelinux.git:6c340c560077dde3eb04d4d66146c239356f81e4)
closed buildArch (rust-miniz_oxide0.8-0.8.9-1.azl4
bootstrap.20260405.src.rpm, x86_64)bootstrap.20260405.src.rpm, aarch64)closed buildArch (rust-miniz_oxide0.8-0.8.9-1.azl4
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology