Skip to content

fix: rust-miniz_oxide0.8: fix upstream-name to match component name#16489

Merged
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-miniz_oxide0.8
Apr 7, 2026
Merged

fix: rust-miniz_oxide0.8: fix upstream-name to match component name#16489
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-miniz_oxide0.8

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 7, 2026

rust-miniz_oxide0.8: fix upstream-name to match component name

koji/taskinfo?taskID=1128265
closed buildSRPMFromSCM (/microsoft/azurelinux.git:6c340c560077dde3eb04d4d66146c239356f81e4)
closed buildArch (rust-miniz_oxide0.8-0.8.9-1.azl4bootstrap.20260405.src.rpm, x86_64)
closed buildArch (rust-miniz_oxide0.8-0.8.9-1.azl4
bootstrap.20260405.src.rpm, aarch64)

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Copilot AI review requested due to automatic review settings April 7, 2026 03:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the component definition for rust-miniz_oxide0.8 to adjust how the Fedora upstream spec source is referenced, aligning with the intent to fetch the correct upstream dist-git content for Azure Linux’s Rust crate packaging.

Changes:

  • Update spec.upstream-name for rust-miniz_oxide0.8.
  • Update the pinned spec.upstream-commit hash for Fedora 43.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is pinned via upstream-commit, but the surrounding comment block doesn’t include a reference link to the upstream dist-git commit (and the pinned commit changed in this PR). Per the comp-toml instructions’ References guidance, please add a full URL to the Fedora src.fedoraproject.org commit (and keep the existing TODO/exit condition) so future readers can audit why/when this pin can be dropped.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-miniz_oxide0.8/c/809f44a243e41106d276040d42cedc618ed5401b

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-miniz_oxide", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "6ff8fbdccbe6b185546f42a70fd93664c3976899" }
spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.upstream-name is intended to override the upstream (Fedora) component name only when it differs from the local component name. After this change it’s identical to the component (rust-miniz_oxide0.8), so it’s redundant and may confuse future readers about whether a rename/mapping is happening. Consider removing upstream-name entirely unless it’s required for a specific tooling reason.

Suggested change
spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-miniz_oxide", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "6ff8fbdccbe6b185546f42a70fd93664c3976899" }
spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/summary indicates an upstream-name fix, but this change also updates the pinned upstream-commit. If the commit change is intentional (e.g., to track the correct dist-git repo/branch for the new upstream-name), please reflect that in the PR description/title so reviewers understand this is also a pin update.

Copilot uses AI. Check for mistakes.
@christopherco christopherco merged commit 1f0d53a into tomls/base/main Apr 7, 2026
9 checks passed
@christopherco christopherco deleted the bphilip/rust-miniz_oxide0.8 branch April 7, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants