Skip to content

fix: rust-miniz_oxide0.8: fix upstream-name to match component name #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 7, 2026
+1 −1
Merged

fix: rust-miniz_oxide0.8: fix upstream-name to match component name #16489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/comps/rust-miniz_oxide0.8/rust-miniz_oxide0.8.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is pinned via upstream-commit, but the surrounding comment block doesn’t include a reference link to the upstream dist-git commit (and the pinned commit changed in this PR). Per the comp-toml instructions’ References guidance, please add a full URL to the Fedora src.fedoraproject.org commit (and keep the existing TODO/exit condition) so future readers can audit why/when this pin can be dropped.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-miniz_oxide0.8/c/809f44a243e41106d276040d42cedc618ed5401b

Copilot uses AI. Check for mistakes.
# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-miniz_oxide", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "6ff8fbdccbe6b185546f42a70fd93664c3976899" }
spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.upstream-name is intended to override the upstream (Fedora) component name only when it differs from the local component name. After this change it’s identical to the component (rust-miniz_oxide0.8), so it’s redundant and may confuse future readers about whether a rename/mapping is happening. Consider removing upstream-name entirely unless it’s required for a specific tooling reason.

Suggested change
spec = { type = "upstream", upstream-name = "rust-miniz_oxide0.8", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "809f44a243e41106d276040d42cedc618ed5401b" }

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/summary indicates an upstream-name fix, but this change also updates the pinned upstream-commit. If the commit change is intentional (e.g., to track the correct dist-git repo/branch for the new upstream-name), please reflect that in the PR description/title so reviewers understand this is also a pin update.

Copilot uses AI. Check for mistakes.
Loading