fix: rust-cssparser0.31: fix upstream-name to match component name#16490
fix: rust-cssparser0.31: fix upstream-name to match component name#16490christopherco merged 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Linux component definition for rust-cssparser0.31, adjusting the upstream spec source configuration used by azldev when fetching from Fedora dist-git.
Changes:
- Updates
spec.upstream-nameforrust-cssparser0.31. - Updates the pinned
spec.upstream-commitfor Fedora 43.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # TODO: Drop this override once the default Fedora 43 snapshot | ||
| # in distro/azurelinux.distro.toml advances past this commit. | ||
| spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" } | ||
| spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" } |
There was a problem hiding this comment.
spec.upstream-name should refer to the Fedora dist-git package name (i.e., the component name in the upstream distro). For version-suffixed Rust components in this repo, upstream-name typically omits the version suffix (e.g., rust-selectors0.25 uses upstream-name = "rust-selectors"). Setting upstream-name = "rust-cssparser0.31" is likely to point to a non-existent Fedora dist-git repo and break azldev source fetching/builds; consider reverting to upstream-name = "rust-cssparser".
| spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" } | |
| spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" } |
| @@ -2,4 +2,4 @@ | |||
| # Pin to the f43 commit used to build the current Fedora 43 package. | |||
There was a problem hiding this comment.
This line changes the upstream-commit pin, but the surrounding comment block doesn’t include a reference URL to the Fedora dist-git commit being pinned (recommended for traceability), and the PR description only mentions upstream-name. Please add a full Fedora dist-git commit URL for the new hash and briefly note in the PR description why the pin changed.
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Pin to the f43 commit used to build the current Fedora 43 package. | |
| # Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-cssparser0.31/c/d80ba243544c8347a14ed079b787dd09d9fba0bd |
rust-cssparser0.31: fix upstream-name to match component name
koji/taskinfo?taskID=1128267
closed buildSRPMFromSCM (/microsoft/azurelinux.git:1572e846f3a49656bad75546199326ba0c7426dd)
closed buildArch (rust-cssparser0.31-0.31.2-1.azl4
bootstrap.20260405.src.rpm, x86_64)bootstrap.20260405.src.rpm, aarch64)closed buildArch (rust-cssparser0.31-0.31.2-1.azl4
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology