Skip to content

fix: rust-cssparser0.31: fix upstream-name to match component name#16490

Merged
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-cssparser0.31
Apr 7, 2026
Merged

fix: rust-cssparser0.31: fix upstream-name to match component name#16490
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/rust-cssparser0.31

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 7, 2026

rust-cssparser0.31: fix upstream-name to match component name

koji/taskinfo?taskID=1128267
closed buildSRPMFromSCM (/microsoft/azurelinux.git:1572e846f3a49656bad75546199326ba0c7426dd)
closed buildArch (rust-cssparser0.31-0.31.2-1.azl4bootstrap.20260405.src.rpm, x86_64)
closed buildArch (rust-cssparser0.31-0.31.2-1.azl4
bootstrap.20260405.src.rpm, aarch64)

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Copilot AI review requested due to automatic review settings April 7, 2026 03:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Linux component definition for rust-cssparser0.31, adjusting the upstream spec source configuration used by azldev when fetching from Fedora dist-git.

Changes:

  • Updates spec.upstream-name for rust-cssparser0.31.
  • Updates the pinned spec.upstream-commit for Fedora 43.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# TODO: Drop this override once the default Fedora 43 snapshot
# in distro/azurelinux.distro.toml advances past this commit.
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "b6fd5d76632012a8ceb9119dac4f18711fde3fb4" }
spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec.upstream-name should refer to the Fedora dist-git package name (i.e., the component name in the upstream distro). For version-suffixed Rust components in this repo, upstream-name typically omits the version suffix (e.g., rust-selectors0.25 uses upstream-name = "rust-selectors"). Setting upstream-name = "rust-cssparser0.31" is likely to point to a non-existent Fedora dist-git repo and break azldev source fetching/builds; consider reverting to upstream-name = "rust-cssparser".

Suggested change
spec = { type = "upstream", upstream-name = "rust-cssparser0.31", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }
spec = { type = "upstream", upstream-name = "rust-cssparser", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d80ba243544c8347a14ed079b787dd09d9fba0bd" }

Copilot uses AI. Check for mistakes.
@@ -2,4 +2,4 @@
# Pin to the f43 commit used to build the current Fedora 43 package.
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changes the upstream-commit pin, but the surrounding comment block doesn’t include a reference URL to the Fedora dist-git commit being pinned (recommended for traceability), and the PR description only mentions upstream-name. Please add a full Fedora dist-git commit URL for the new hash and briefly note in the PR description why the pin changed.

Suggested change
# Pin to the f43 commit used to build the current Fedora 43 package.
# Pin to the f43 commit used to build the current Fedora 43 package.
# Fedora dist-git commit: https://src.fedoraproject.org/rpms/rust-cssparser0.31/c/d80ba243544c8347a14ed079b787dd09d9fba0bd

Copilot uses AI. Check for mistakes.
@christopherco christopherco merged commit d572edb into tomls/base/main Apr 7, 2026
9 checks passed
@christopherco christopherco deleted the bphilip/rust-cssparser0.31 branch April 7, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants